Labels Milestones

Simplify naming #4

Closed

Warr1024 wants to merge 1 commits from Warr1024/lc_liberties:renaming into master

pull from: Warr1024/lc_liberties:renaming

merge into: lizzie:master

lizzie:master

Conversation 1 Commits 1 Files Changed 1

Warr1024 commented 1 year ago

The idea of reusing the "stone" from the name was clever, but it has some drawbacks.

• It doesn't fit in with NodeCore's generally purely concatenative naming scheme, where adjectives are prepended to general names for things.
• It would make translations (or just general understanding) more difficult for non-native speakers.
• It's a little weird separating certain words, like tarstone and cloudstone, because "tar" and "cloud" appearing on their own now seem to imply that that material is somehow used in the composition of the go stones.

Having all of the stones have "go" in their name also reinforces that these pieces are meant to be part of a logical set, used together, and are meant to be used for the game of go (in case somebody sees one in isolation and doesn't know what it's
from).

It also makes it easier to just search for "go" in szutil_givemenu and find all the go stones; searching for "stone" yields too many results.

The idea of reusing the "stone" from the name was clever, but it has some drawbacks. - It doesn't fit in with NodeCore's generally purely concatenative naming scheme, where adjectives are prepended to general names for things. - It would make translations (or just general understanding) more difficult for non-native speakers. - It's a little weird separating certain words, like tarstone and cloudstone, because "tar" and "cloud" appearing on their own now seem to imply that that material is somehow used in the composition of the go stones. Having all of the stones have "go" in their name also reinforces that these pieces are meant to be part of a logical set, used together, and are meant to be used for the game of go (in case somebody sees one in isolation and doesn't know what it's from). It also makes it easier to just search for "go" in szutil_givemenu and find all the go stones; searching for "stone" yields too many results.

Warr1024 added 1 commit 1 year ago

ad8ba5a50b Simplify naming ...

The idea of reusing the "stone" from the name was
clever, but it has some drawbacks.

- It doesn't fit in with NodeCore's generally purely
  concatenative naming scheme, where adjectives
  are prepended to general names for things.
- It would make translations (or just general
  understanding) more difficult for non-native
  speakers.
- It's a little weird separating certain words, like
  tarstone and cloudstone, because "tar" and
  "cloud" appearing on their own now seem to
  imply that that material is somehow used in the
  composition of the go stones.

Having all of the stones have "go" in their name
also reinforces that these pieces are meant to be
part of a logical set, used together, and are meant
to be used for the game of go (in case somebody
sees one in isolation and doesn't know what it's
from).

It also makes it easier to just search for "go" in
szutil_givemenu and find all the go stones;
searching for "stone" yields too many results.

lizzie commented 1 year ago

Owner

I came up with a compromise solution.

I came up with a compromise solution.

lizzie closed this pull request 1 year ago

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

No items

No Label

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lizzie/lc_liberties#4

Write Preview

Loading…

Cancel

Save

There is no content yet.