Update TODOs

main
copygirl 10 months ago
parent 755b1ae520
commit a618b58989
  1. 1
      player/Player.cs
  2. 1
      scenes/ItemManager.cs
  3. 1
      scripts/globals/RPC.cs

@ -3,7 +3,6 @@ public partial class Player : CharacterBody3D
public int PeerId => GetMultiplayerAuthority(); public int PeerId => GetMultiplayerAuthority();
public bool IsLocal => this.IsAuthority(); public bool IsLocal => this.IsAuthority();
// TODO: Add "Controller" suffix to these.
public MovementController Movement { get; private set; } public MovementController Movement { get; private set; }
public CameraController Camera { get; private set; } public CameraController Camera { get; private set; }
public AnimationController Animation { get; private set; } public AnimationController Animation { get; private set; }

@ -34,6 +34,7 @@ public partial class ItemManager : Node
// FIXME: This should be fixed in 4.3 and thus not required anymore? // FIXME: This should be fixed in 4.3 and thus not required anymore?
// FIXME: Don't actually rely on item path, use its TrackingId.
// https://github.com/godotengine/godot/issues/85883 // https://github.com/godotengine/godot/issues/85883
internal enum RequestFunc { RequestPickup, RequestPlace, RequestThrow } internal enum RequestFunc { RequestPickup, RequestPlace, RequestThrow }

@ -43,7 +43,6 @@ public class RPC
void SendInternal(Node node, StringName method, params Variant[] args) void SendInternal(Node node, StringName method, params Variant[] args)
{ {
if ((_targets == null) && (_except == null)) if ((_targets == null) && (_except == null))
// TODO: Check if RpcId is recommended for client -> server messages over just Rpc.
node.Rpc(method, args); node.Rpc(method, args);
else { else {
var targets = _targets ?? node.Multiplayer.GetPeers(); var targets = _targets ?? node.Multiplayer.GetPeers();

Loading…
Cancel
Save