From 4f0d5a537e77fa647a47c58fbdd4300d4d705403 Mon Sep 17 00:00:00 2001 From: copygirl Date: Fri, 16 Apr 2021 19:46:19 +0200 Subject: [PATCH] Use QueueFree instead of RemoveChild --- src/Extensions.cs | 3 --- src/Network.cs | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/Extensions.cs b/src/Extensions.cs index 15504dc..3121271 100644 --- a/src/Extensions.cs +++ b/src/Extensions.cs @@ -2,9 +2,6 @@ using Godot; public static class Extensions { - public static void RemoveFromParent(this Node @this) - => @this.GetParent().RemoveChild(@this); - public static T Init(this PackedScene @this) where T : Node { diff --git a/src/Network.cs b/src/Network.cs index f290c91..28c8158 100644 --- a/src/Network.cs +++ b/src/Network.cs @@ -78,7 +78,7 @@ public class Network : Node LocalPlayer.Instance.NetworkID = -1; foreach (var player in _playersById.Values) if (!player.IsLocal) - player.RemoveFromParent(); + player.QueueFree(); _playersById.Clear(); } @@ -224,7 +224,7 @@ public class Network : Node private void OnPeerDisconnected(int id) { - GetPlayer(id)?.RemoveFromParent(); + GetPlayer(id)?.QueueFree(); _playersById.Remove(id); } }